chore: tune return msg #2506
Merged
chore: tune return msg #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
shuiyisong
requested review from
sunng87,
MichaelScofield,
evenyag,
waynexia and
fengys1996
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2506 +/- ##
===========================================
- Coverage 85.25% 84.90% -0.36%
===========================================
Files 729 729
Lines 115862 115914 +52
===========================================
- Hits 98780 98414 -366
- Misses 17082 17500 +418 |
sunng87
approved these changes
Sep 27, 2023
sunng87
reviewed
Sep 27, 2023
waynexia
approved these changes
Sep 27, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: test return msg * fix: test_child_error Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * chore: fix test * chore: minor fix grpc return value * chore: format return msg * chore: use root error as return value * chore: fix empty err display * chore: iter through external error * chore: remove err msg * chore: remove unused field --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Now errors are divided into 2 kinds
std::io::ERRORwe now return the source error's message to client (e.g: mysql client, http response, etc.)
{error}is returned, content of message should be#[snafu(display)]{error}: {external_err}is returned for detail explanation.Checklist
Refer to a related PR or issue link (optional)
This pr should hopefully be the last one for #1854.